build: fix mdc slider demo #19635
Merged
build: fix mdc slider demo #19635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
In angular#19411 the MDC slider theme was dropped from the all themes mixin since the current slider implementation will be replaced eventually which also broke the MDC slider demo. These changes add back the slider theme only to the dev app so that we can still test it since this is still code that we're releasing to npm.
crisbeto
force-pushed
the
mdc-slider-dev-app
branch
from
c3e99a9 to
2a74be1
Compare
andrewseguin
pushed a commit
that referenced
this pull request
Jun 15, 2020
In #19411 the MDC slider theme was dropped from the all themes mixin since the current slider implementation will be replaced eventually which also broke the MDC slider demo. These changes add back the slider theme only to the dev app so that we can still test it since this is still code that we're releasing to npm.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #19411 the MDC slider theme was dropped from the all themes mixin since the current slider implementation will be replaced eventually which also broke the MDC slider demo. These changes add back the slider theme only to the dev app so that we can still test it since this is still code that we're releasing to npm.